[libcxx-commits] [PATCH] D81425: [libc++] Don't force a conversion to difference_type in std::advance

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 8 13:52:05 PDT 2020


ldionne added a comment.

@mclow.lists  I'm curious to hear what you think about this patch.

I think it's weird to have a wide open template parameter like this in `std::distance`, but it appears to be what the Standard wants. And using `difference_type` leads to warnings when passing an unsigned type when `-Wsign-conversion` is enabled (which is where this change comes from).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81425/new/

https://reviews.llvm.org/D81425





More information about the libcxx-commits mailing list