[libcxx-commits] [libcxx] e25f01b - [libcxx testing] Fix bot failure in my last commit

David Zarzycki via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 3 08:28:35 PDT 2020


Author: David Zarzycki
Date: 2020-06-03T11:28:14-04:00
New Revision: e25f01be0c4c4f0355ae645599b3f54acb712ddd

URL: https://github.com/llvm/llvm-project/commit/e25f01be0c4c4f0355ae645599b3f54acb712ddd
DIFF: https://github.com/llvm/llvm-project/commit/e25f01be0c4c4f0355ae645599b3f54acb712ddd.diff

LOG: [libcxx testing] Fix bot failure in my last commit

Added: 
    

Modified: 
    libcxx/test/std/thread/thread.condition/thread.condition.condvarany/notify_all.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/thread/thread.condition/thread.condition.condvarany/notify_all.pass.cpp b/libcxx/test/std/thread/thread.condition/thread.condition.condvarany/notify_all.pass.cpp
index ebac6426d6c2..0e19e5925eeb 100644
--- a/libcxx/test/std/thread/thread.condition/thread.condition.condvarany/notify_all.pass.cpp
+++ b/libcxx/test/std/thread/thread.condition/thread.condition.condvarany/notify_all.pass.cpp
@@ -18,6 +18,7 @@
 #include <mutex>
 #include <thread>
 #include <vector>
+#include <atomic>
 #include <cassert>
 
 #include "test_macros.h"
@@ -45,7 +46,7 @@ int main(int, char**)
   notReady = threadCount;
   std::vector<std::thread> threads;
   for (unsigned i = 0; i < threadCount; i++)
-    threads.push_back(std::thread(helper));
+    threads.emplace_back(helper);
   {
     while (notReady > 0)
       std::this_thread::yield();


        


More information about the libcxx-commits mailing list