[libcxx-commits] [PATCH] D80790: [libc++] Remove redundant empty specialization in std::array

Tue Jun 2 08:47:03 PDT 2020

ldionne abandoned this revision.
ldionne added a comment.

In D80790#2063869 <https://reviews.llvm.org/D80790#2063869>, @miscco wrote:

> I have to say that this is rather worse than what we had before.
>
> With this change we have
>
> - A higher implementation complexity. What was previously super simple is now quite complex

How is it quite complex? I'm just de-duplicating all the member functions like `size()` & friends. IMO it's a lot simpler after the change. I'll abandon this for now and revisit once the situation with `array<T, 0>` has settled -- this patch can be made simpler then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80790/new/

https://reviews.llvm.org/D80790