[libcxx-commits] [PATCH] D80895: [libcxx] adds operator<=> for basic_string

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added inline comments.


================
Comment at: libcxx/include/string:3909
 bool
 operator==(const basic_string<char, char_traits<char>, _Allocator>& __lhs,
            const basic_string<char, char_traits<char>, _Allocator>& __rhs) _NOEXCEPT
----------------
cjdb wrote:
> miscco wrote:
> > I think you are missing this specialization below. That said, I am unsure whether this is actually needed at all.
> I assume Howard had his reasons, so I've moved it outside of the block, just in case. Will delete at someone's request.
That sounds reasonable. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80895/new/

https://reviews.llvm.org/D80895