[libcxx-commits] [PATCH] D80899: [libcxx] adds std::compare_three_way

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 1 09:06:42 PDT 2020


cjdb added inline comments.


================
Comment at: libcxx/include/functional:515
 
+#if !defined(_LIBCPP_HAS_NO_SPACESHIP_OPERATOR)
+#include <compare>
----------------
miscco wrote:
> Usually this is spellec as `#ifndef _LIBCPP_HAS_NO_SPACESHIP_OPERATOR`
Ack, I am following convention I've seen elsewhere. lmk if this is a hard sell and I can change it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80899/new/

https://reviews.llvm.org/D80899





More information about the libcxx-commits mailing list