[libcxx-commits] [PATCH] D80895: [libcxx] adds operator<=> for basic_string
Christopher Di Bella via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Jun 1 08:37:51 PDT 2020
cjdb added inline comments.
Comment at: libcxx/include/string:362
-template<class charT, class traits, class Allocator>
-bool operator==(const charT* lhs, const basic_string<charT, traits, Allocator>& rhs) noexcept;
> I think we should not delete them from the synopsis as they are used in pre C++20 mode. You could mark them with // until C++17 and then spaceship with // C++20
Thanks! I was wondering how to address this problem...
Comment at: libcxx/include/string:3909
operator==(const basic_string<char, char_traits<char>, _Allocator>& __lhs,
const basic_string<char, char_traits<char>, _Allocator>& __rhs) _NOEXCEPT
> I think you are missing this specialization below. That said, I am unsure whether this is actually needed at all.
I assume Howard had his reasons, so I've moved it outside of the block, just in case. Will delete at someone's request.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits