[libcxx-commits] [PATCH] D84275: [Libcxx] Finish implementing Paper 0202R3

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.sorting/alg.merge/merge.pass.cpp:36
+                       std::end(ib), std::begin(ic));
+  assert(
+      std::distance(std::begin(ic), it) == (std::size(ia) + std::size(ib)) &&
----------------
Almost perfect. Can you make each check an individual `assert`? That makes it easier to figure out what went wrong if the tests start failing. 

This should be:
```
assert(std::distance(...) == (...));
assert(*it == 0);
assert(std::equal(...));
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84275/new/

https://reviews.llvm.org/D84275