[libcxx-commits] [libcxx] e59778a - [libcxx] Fix default argument for merge_archives.py -L flag

Alex Richardson via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 22 10:33:07 PDT 2020


Author: Alex Richardson
Date: 2020-07-22T18:32:34+01:00
New Revision: e59778a66a91225c3f9c7b46e3e86e50994dbe14

URL: https://github.com/llvm/llvm-project/commit/e59778a66a91225c3f9c7b46e3e86e50994dbe14
DIFF: https://github.com/llvm/llvm-project/commit/e59778a66a91225c3f9c7b46e3e86e50994dbe14.diff

LOG: [libcxx] Fix default argument for merge_archives.py -L flag

If we use the default of None, we get a python exception in
find_and_diagnose_missing() instead of printing a sensible error message.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D84342

Added: 
    

Modified: 
    libcxx/utils/merge_archives.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/merge_archives.py b/libcxx/utils/merge_archives.py
index cc96cb2aa50c..d751526359ba 100755
--- a/libcxx/utils/merge_archives.py
+++ b/libcxx/utils/merge_archives.py
@@ -93,7 +93,7 @@ def main():
     parser.add_argument(
         '-L', dest='search_paths',
         help='Paths to search for the libraries along', action='append',
-        nargs=1)
+        nargs=1, default=[])
     parser.add_argument(
         '--ar', dest='ar_exe', required=False,
         help='The ar executable to use, finds \'ar\' in the path if not given',


        


More information about the libcxx-commits mailing list