[libcxx-commits] [PATCH] D84342: [libcxx] Fix default argument for merge_archives.py -L flag

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson created this revision.
arichardson added a reviewer: EricWF.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

If we use the default of None, we get a python exception in
find_and_diagnose_missing() instead of printing a sensible error message.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84342

Files:
  libcxx/utils/merge_archives.py


Index: libcxx/utils/merge_archives.py
===================================================================
--- libcxx/utils/merge_archives.py
+++ libcxx/utils/merge_archives.py
@@ -93,7 +93,7 @@
     parser.add_argument(
         '-L', dest='search_paths',
         help='Paths to search for the libraries along', action='append',
-        nargs=1)
+        nargs=1, default=[])
     parser.add_argument(
         '--ar', dest='ar_exe', required=False,
         help='The ar executable to use, finds \'ar\' in the path if not given',


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84342.279867.patch
Type: text/x-patch
Size: 533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200722/69a1f0dc/attachment-0001.bin>