[libcxx-commits] [PATCH] D84096: [libcxx][lit] Simplify parsing of trailing executor arguments

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 21 01:53:33 PDT 2020


arichardson added a comment.

I noticed that llvm/libcxx/test/std/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.class/lock.pass.cpp failed after my commit, but it seems to me that this test (and all the others in that directory) should not be assuming that the wait will be less than x milliseconds. I believe I worked around this in our CHERI fork by increasing the timeout for slow emulated systems, but that could still fail in some cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84096/new/

https://reviews.llvm.org/D84096





More information about the libcxx-commits mailing list