[libcxx-commits] [PATCH] D84055: [libcxx][lit] Cache the value of the feature lambda

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

This doesn't work, since a feature could be supported in one configuration but not in another one. The caching would have to take into account the `config`.

Instead, I believe caching should be implemented at a lower level, i.e. where we run the actual locale tests. That's where we know the command-line we use to compile the test and the locale we're testing. Note that we originally cached `subprocess.call` calls, but this was removed when we moved to creating mini-Lit tests for configuration checks. I believe implementing caching of some sort at that lower level would be more sound and would yield potentially even larger benefits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84055/new/

https://reviews.llvm.org/D84055