[libcxx-commits] [PATCH] D82702: [libc++] Use a proper CMake target to represent libc++ headers

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D82702#2151557 <https://reviews.llvm.org/D82702#2151557>, @aeubanks wrote:

> Hi, I think this is causing our Mac bots to fail when building libcxx, with
>
> /opt/s/w/ir/cache/xcode_ios_11a1027.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -DNDEBUG -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iprojects/libcxx/src -I/opt/s/w/ir/cache/builder/src/third_party/llvm/libcxx/src -I/opt/s/w/ir/cache/xcode_ios_11a1027.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/libxml2 -Iinclude -I/opt/s/w/ir/cache/builder/src/third_party/llvm/llvm/include -Iprojects/libcxx/include/c++build -DLLVM_FORCE_HEAD_REVISION -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers  -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -O3  -isysroot /opt/s/w/ir/cache/xcode_ios_11a1027.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.14   -DLIBCXX_BUILDING_LIBCXXABI -UNDEBUG -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -W -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wno-user-defined-literals -Wno-covered-switch-default -Wno-ignored-attributes -Wno-error -std=c++14 -MD -MT projects/libcxx/src/CMakeFiles/cxx_experimental.dir/experimental/memory_resource.cpp.o -MF projects/libcxx/src/CMakeFiles/cxx_experimental.dir/experimental/memory_resource.cpp.o.d -o projects/libcxx/src/CMakeFiles/cxx_experimental.dir/experimental/memory_resource.cpp.o -c /opt/s/w/ir/cache/builder/src/third_party/llvm/libcxx/src/experimental/memory_resource.cpp
>  /opt/s/w/ir/cache/builder/src/third_party/llvm/libcxx/src/experimental/memory_resource.cpp:9:10: fatal error: 'experimental/memory_resource' file not found
>  #include "experimental/memory_resource"
>
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> 1 error generated.
>
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874769072373415488/+/steps/gclient_runhooks/0/stdout
>
> Is this intended?


This looks the issue I've been investigating, but it seems like the workaround I suggested doesn't help here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82702/new/

https://reviews.llvm.org/D82702