[libcxx-commits] [PATCH] D83274: Remove the unnecessary `is_nothrow_swappable` condition in `swap`.

Michael Park via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 8 10:47:14 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG6ab3208d779f: Remove the unnecessary `is_nothrow_swappable` condition in `swap`. (authored by mpark).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83274/new/

https://reviews.llvm.org/D83274

Files:
  libcxx/include/variant


Index: libcxx/include/variant
===================================================================
--- libcxx/include/variant
+++ libcxx/include/variant
@@ -1063,8 +1063,7 @@
       }
       __impl __tmp(_VSTD::move(*__rhs));
 #ifndef _LIBCPP_NO_EXCEPTIONS
-      if constexpr (__all<(is_nothrow_move_constructible_v<_Types> &&
-                           is_nothrow_swappable_v<_Types>)...>::value) {
+      if constexpr (__all<is_nothrow_move_constructible_v<_Types>...>::value) {
         this->__generic_construct(*__rhs, _VSTD::move(*__lhs));
       } else {
         // EXTENSION: When the move construction of `__lhs` into `__rhs` throws


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83274.276490.patch
Type: text/x-patch
Size: 644 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200708/72e87dc3/attachment.bin>


More information about the libcxx-commits mailing list