[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

Mon Jul 6 00:34:58 PDT 2020

phosek added a comment.

In D82490#2132087 <https://reviews.llvm.org/D82490#2132087>, @oontvoo wrote:

> Does this only happen on Fuchsia? How do I repro it?

I don't know if it's just Fuchsia, but we use the unstable libc++ ABI by default and we always do a 2-stage build which is probably why we're seeing this on our builders but not on others.

You can see all the steps on Fuchsia buildbot builder <http://lab.llvm.org:8011/builders/fuchsia-x86_64-linux>, e.g. http://lab.llvm.org:8011/builders/fuchsia-x86_64-linux/builds/7643

> (I've run the tests `make check-cxx` and didn't see any issue)
> 
> Thanks!
> 
> P.S:
> 
> I've tried the following (w/o the fuchsia stuff) and couldn't reproduce it :
> 
>    ./bin/clang++ -stdlib=libc++ -nostdinc++  \
>      -L$LIBCXX_CHECKOUT/build/lib  \
>      -I$LIBCXX_CHECKOUT/build/include/c++/v1 -DDEBUG \
>   -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC -fvisibility-inlines-hidden -Werror=date-time  -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -Wno-user-defined-literals -ffunction-sections -fdata-sections -O2 -g  -fPIC -DLIBCXX_BUILDING_LIBCXXABI  -std=c++14 -MD  -UNDEBUG ../libcxx/src/any.cpp 
>   /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/crt1.o: in function `_start':
>   (.text+0x20): undefined reference to `main'
>   clang-11: error: linker command failed with exit code 1 (use -v to see invocation)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490