[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Thanks a lot for the added tests, this looks almost good to go.



================
Comment at: libcxx/include/__config:108
 #  define _LIBCPP_ABI_STRING_OPTIMIZED_EXTERNAL_INSTANTIATION
+#  if __has_cpp_attribute(clang::trivial_abi)
+//   Enable clang::trivial_abi on std::unique_ptr.
----------------
We shouldn't have such an important ABI property be dependent on compiler versions like this. I think we should unconditionally use the attribute -- it's fine to assume that someone tweaking these ABI flags is on a recent Clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490