[libcxx-commits] [PATCH] D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb marked an inline comment as done.
broadwaylamb added inline comments.


================
Comment at: libcxxabi/CMakeLists.txt:99
+
+option(LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXX
+       "Whether the libc++abi tests should link with the shared libc++ library"
----------------
phosek wrote:
> Have you considered using `cmake_dependent_option`? That way you don't need to do the validation below yourself.
I have considered it, but I couldn't come up with proper conditions that would encode this logic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71894/new/

https://reviews.llvm.org/D71894