[libcxx-commits] [PATCH] D73525: [CMake][libcxx] Don't wrap __config_site path in quotes on Windows

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 29 19:41:39 PST 2020


phosek updated this revision to Diff 241339.
phosek marked 3 inline comments as done.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73525/new/

https://reviews.llvm.org/D73525

Files:
  libcxx/CMakeLists.txt


Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -878,7 +878,7 @@
 function(cxx_add_config_site target)
   if (LIBCXX_NEEDS_SITE_CONFIG)
     if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" OR "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
-      target_compile_options(${target} PUBLIC "/FI\"${site_config_path}\"")
+      target_compile_options(${target} PUBLIC /FI "${site_config_path}")
     else()
       target_compile_options(${target} PUBLIC -include "${site_config_path}")
     endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73525.241339.patch
Type: text/x-patch
Size: 593 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200130/8818faf6/attachment.bin>


More information about the libcxx-commits mailing list