[libcxx-commits] [libcxx] 7f49dc4 - [CMake][libcxx] Don't wrap __config_site path in quotes on Windows

Petr Hosek via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 29 19:37:45 PST 2020


Author: Petr Hosek
Date: 2020-01-29T19:37:35-08:00
New Revision: 7f49dc496682e38335b204bbae371a0ca5057719

URL: https://github.com/llvm/llvm-project/commit/7f49dc496682e38335b204bbae371a0ca5057719
DIFF: https://github.com/llvm/llvm-project/commit/7f49dc496682e38335b204bbae371a0ca5057719.diff

LOG: [CMake][libcxx] Don't wrap __config_site path in quotes on Windows

This is failing to compile on Windows because clang-cl is trying to
use the path with quotes, dropping them resolves the issue.

Differential Revision: https://reviews.llvm.org/D73525

Added: 
    

Modified: 
    libcxx/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libcxx/CMakeLists.txt b/libcxx/CMakeLists.txt
index 9e84fa71a32b..f6097a37c71e 100644
--- a/libcxx/CMakeLists.txt
+++ b/libcxx/CMakeLists.txt
@@ -878,7 +878,7 @@ endif()
 function(cxx_add_config_site target)
   if (LIBCXX_NEEDS_SITE_CONFIG)
     if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" OR "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
-      target_compile_options(${target} PUBLIC "/FI\"${site_config_path}\"")
+      target_compile_options(${target} PUBLIC /FI "${site_config_path}")
     else()
       target_compile_options(${target} PUBLIC -include "${site_config_path}")
     endif()


        


More information about the libcxx-commits mailing list