[libcxx-commits] [PATCH] D72952: [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D72952#1840841 <https://reviews.llvm.org/D72952#1840841>, @mstorsjo wrote:

> In D72952#1840794 <https://reviews.llvm.org/D72952#1840794>, @mstorsjo wrote:
>
> > This broke my build, for both mingw and linux, with both cmake 3.10.2 and 3.16.2 - the assembly files don't get built at all. Reproducible on linux with a plain "cmake .." (in llvm-project/libunwind/build) without further args.
> >
> > Is some custom build config needed for this to work?
>
>
> Ok, so it seems this works when built via the main llvm cmakefile, but not standalone. So I guess the libunwind cmakefiles needs some extras for hooking this up, that are included only when built standalone.


I fixed this in https://reviews.llvm.org/rG0e0c65264aeb6f66b6f711884c55cdbf66d975f6, but building assembly files as assembly instead of C breaks building for mingw, for which I sent an additional patch at D73436 <https://reviews.llvm.org/D73436>, essentially conditionally reverting this change for mingw targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72952/new/

https://reviews.llvm.org/D72952