[libcxx-commits] [PATCH] D72501: [libcxx] Support Python 3.8 in the test suite

Jonathan Roelofs via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 21 07:07:42 PST 2020


jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.

Either way, LGTM.



================
Comment at: libcxx/utils/libcxx/test/target_info.py:216
+            # Python 3.8.
+            return platform.linux_distribution()
+        except AttributeError:
----------------
Did you consider using this instead? One downside is that it brings in one more dependency.


```
import distro
return distro.linux_distribution(full_distribution_name=False)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72501/new/

https://reviews.llvm.org/D72501





More information about the libcxx-commits mailing list