[libcxx-commits] [PATCH] D72160: Optimize / partially inline basic_string copy constructor

Eric Fiselier via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 20 17:32:53 PST 2020


I can reproduce on linux. Also there are some additional failures that have
been brought to my attention.
I'll spend the night working on it, and if I can't figure it out I'll
revert.

My sneaking suspicion is that the patch is correct, but it's triggering
latent UB by allowing the compiler to
see the entire body of the constructor where it couldn't before.

/Eric

On Mon, Jan 20, 2020 at 6:17 AM Michał Górny <mgorny at gentoo.org> wrote:

> On Mon, 2020-01-20 at 05:40 -0500, Eric Fiselier wrote:
> > I'm failing to see how libc++ is being used as the standard library in
> > stage1 or stage2.
> > Is libc++ the default standard library for Clang on NetBSD?
> >
>
> Yes, it is.  I suppose I should've guessed that's what you're looking
> for.
>
> Can't you reproduce it on your system?  If you want me to, I can try to
> reproduce it on Linux but it'll take a few hours.
>
> --
> Best regards,
> Michał Górny
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200120/5893bb46/attachment.html>


More information about the libcxx-commits mailing list