[libcxx-commits] [PATCH] D72160: Optimize / partially inline basic_string copy constructor

Martijn Vels via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 17 12:28:43 PST 2020


mvels marked 4 inline comments as done.
mvels added inline comments.


================
Comment at: libcxx/include/string:804
+    // initialization is delegated to the (external) __init_long()method,
+    // which results in a 3X-4X speed up for SSO initialization.
     basic_string(const basic_string& __str);
----------------
EricWF wrote:
> Numbers never age well in comments.  I would put them in the commit message instead.
Removed reference, it will pop in the commit once we do the inlining :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72160/new/

https://reviews.llvm.org/D72160





More information about the libcxx-commits mailing list