[libcxx-commits] [PATCH] D72862: [libcxx] Temporarily switch back to pthread backend for Fuchsia

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 16 12:18:24 PST 2020


phosek created this revision.
phosek added reviewers: EricWF, leonardchan.
Herald added subscribers: libcxx-commits, jfb, ldionne, christof.
Herald added a project: libc++.

We switched to C11 thread API on Fuchsia in ab9aefe <https://reviews.llvm.org/rGab9aefee9fa09957d1a3e76fcc47abda0d002255>, but further
testing showed that Fuchsia's C11 mutex implementation needs a few
improvements for this to be usable, so we temporarily switch back
to the pthread implementation until those issues are addressed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72862

Files:
  libcxx/include/__config


Index: libcxx/include/__config
===================================================================
--- libcxx/include/__config
+++ libcxx/include/__config
@@ -1115,6 +1115,7 @@
     !defined(_LIBCPP_HAS_THREAD_API_WIN32) && \
     !defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
 #  if defined(__FreeBSD__) || \
+      defined(__Fuchsia__) || \
       defined(__wasi__) || \
       defined(__NetBSD__) || \
       defined(__linux__) || \
@@ -1124,8 +1125,6 @@
       defined(__sun__) || \
       (defined(__MINGW32__) && __has_include(<pthread.h>))
 #    define _LIBCPP_HAS_THREAD_API_PTHREAD
-#  elif defined(__Fuchsia__)
-#    define _LIBCPP_HAS_THREAD_API_C11
 #  elif defined(_LIBCPP_WIN32API)
 #    define _LIBCPP_HAS_THREAD_API_WIN32
 #  else


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72862.238572.patch
Type: text/x-patch
Size: 743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200116/93ef7e37/attachment.bin>


More information about the libcxx-commits mailing list