[libcxx-commits] [PATCH] D68480: Implementation of C++20's P1135R6 for libcxx

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D68480#1893953 <https://reviews.llvm.org/D68480#1893953>, @leonardchan wrote:

> Hi, a bisect shows that this patch seems to cause time.h to not be found for us:
>  [...]
>
> Do you know if this is a known or unintended side effect of this patch? I don't think we changed anything on our side that would've caused this.


This must be cause we're now including `<chrono>` in `<atomic>`. This is not really something we can (or want to) workaround, since that's in the spec. Are you folks using some fancy C library that doesn't provide `<time.h>`? If so, I would argue that the fact it worked before this patch is just a coincidence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68480/new/

https://reviews.llvm.org/D68480