[libcxx-commits] [PATCH] D75074: [libc++] Proper fix for libc++'s modulemap after D68480

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 24 13:52:47 PST 2020


EricWF added a comment.

In D75074#1889993 <https://reviews.llvm.org/D75074#1889993>, @ldionne wrote:

> @EricWF I'm unsure about this change -- I think we might want to keep the `requires` in the modulemap but also get rid of the `#error` behavior.


I would agree with that.

LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75074/new/

https://reviews.llvm.org/D75074





More information about the libcxx-commits mailing list