[libcxx-commits] [PATCH] D73743: Inline basic_string::erase for fastpath where __n == npos

Wed Feb 19 15:15:11 PST 2020

smeenai added a comment.

In D73743#1883768 <https://reviews.llvm.org/D73743#1883768>, @mvels wrote:

> Is there a way I can easily tell phabricator that this is baselined against https://reviews.llvm.org/D74870 ?
>
> I admit I don't understand phabricator well, or the mysterious ways it works.
>
> On my local repo I rebased my branch, which works like a charm as that is ..... basic git.
>  Unfortunately arc diff then updates the wrong review, so I had to fix up both this one and D74870 <https://reviews.llvm.org/D74870>,
>
> I also figured setting 'parent revision' would establish this (not so much).
>
> Should I RTFM? :)

Try `arc diff HEAD^`.

We should just adjust the .arcconfig for LLVM to do this automatically ... I'll put up a patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73743/new/

https://reviews.llvm.org/D73743