[libcxx-commits] [PATCH] D74870: Split _LIBCPP_STRING_EXTERN_TEMPLATE_LIST up into a V1 and UNSTABLE version.

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

My personal preference is to not split the lists, my rational is:

- It encourages unstable to deviate from stable more. I would like us to keep the code and instantiations between the two as similar as possible. The more they differ, the more it is to maintain and the more likely it is that one contains bugs or starts to rot.
- It's useful to see the difference between stable and unstable at a glance. Having two lists makes it much harder.

For reference, here's my attempt at a similar thing:
https://reviews.llvm.org/D73807



================
Comment at: libcxx/include/__string:76
+
+// The extern template ABI lists are kept outside of <string> to improve the
+// readability of that header. We maintain 2 ABI lists:
----------------
We should add a design doc for all @mvels work on `std::string` and its instantiations.

See http://libcxx.llvm.org/docs/#design-documents for a list of current design docs, so you can see how libc++ does them.
They can be found in the source tree under libcxx/docs/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74870/new/

https://reviews.llvm.org/D74870