[libcxx-commits] [PATCH] D74626: [libc++] Add availability markup for std::to_chars on Apple platforms

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Feb 15 10:45:23 PST 2020


ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/test/std/utilities/charconv/charconv.from.chars/integral.roundtrip.pass.cpp:35
+template <typename T>
+struct test_basics : roundtrip_test_base<T>
+{
----------------
lichray wrote:
> +1 for the split.
This has the added benefit that we can test from_chars independently on all platforms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74626/new/

https://reviews.llvm.org/D74626





More information about the libcxx-commits mailing list