[libcxx-commits] [PATCH] D74291: [libcxx] Adds [concept.same]

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added inline comments.


================
Comment at: libcxx/test/std/concepts/lang/same_as.pass.cpp:46
+class C4 {
+  int t1;
+  int t2;
----------------
Out of curiosity should that be `T1 t1;` and below `T2 t2; `


================
Comment at: libcxx/test/std/concepts/lang/same_as.pass.cpp:188
+    // Checks std::same_as<const T, const T> is true
+    CheckSameAs<std::add_const>();
+
----------------
Nitpick, if we go for all the different qualifiers/references there should be a test for volatile to

```
    // Checks std::same_as<volatile T, volatile T> is true
    CheckSameAs<std::add_volatile>();
````


================
Comment at: libcxx/test/std/concepts/lang/same_as.pass.cpp:229
+    CheckNotSameAs<std::add_rvalue_reference, std::add_lvalue_reference>();
+  }
+
----------------
Same as above volatile is missing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74291/new/

https://reviews.llvm.org/D74291