[libcxx-commits] [libcxx] f2af4f8 - [libc++][span] Add failing tests for span::first and span::last

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-02-10T13:52:20+01:00
New Revision: f2af4f8a45dbd0d1de950a64f1b4fbf618c70657

URL: https://github.com/llvm/llvm-project/commit/f2af4f8a45dbd0d1de950a64f1b4fbf618c70657
DIFF: https://github.com/llvm/llvm-project/commit/f2af4f8a45dbd0d1de950a64f1b4fbf618c70657.diff

LOG: [libc++][span] Add failing tests for span::first and span::last

Both methods have compile time constraints that we should test against.

Patch by Michael Schellenberger Costa

Differential Revision: https://reviews.llvm.org/D71999

Added: 
    libcxx/test/std/containers/views/span.sub/first.fail.cpp
    libcxx/test/std/containers/views/span.sub/last.fail.cpp

Modified: 
    libcxx/test/std/containers/views/span.sub/first.pass.cpp
    libcxx/test/std/containers/views/span.sub/last.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/containers/views/span.sub/first.fail.cpp b/libcxx/test/std/containers/views/span.sub/first.fail.cpp
new file mode 100644
index 000000000000..5bced0c9f3a2
--- /dev/null
+++ b/libcxx/test/std/containers/views/span.sub/first.fail.cpp
@@ -0,0 +1,40 @@
+// -*- C++ -*-
+//===------------------------------ span ---------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===---------------------------------------------------------------------===//
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
+
+// <span>
+
+// template<size_t Count>
+//  constexpr span<element_type, Count> first() const;
+//
+// constexpr span<element_type, dynamic_extent> first(size_type count) const;
+//
+//  Requires: Count <= size().
+
+#include <span>
+
+#include "test_macros.h"
+
+constexpr int carr[] = {1, 2, 3, 4};
+
+int main(int, char**) {
+  std::span<const int, 4> sp(carr);
+
+  //  Count too large
+  {
+    [[maybe_unused]] auto s1 = sp.first<5>(); // expected-error-re at span:* {{static_assert failed{{( due to requirement '.*')?}} "Count out of range in span::first()"}}
+  }
+
+  //  Count numeric_limits
+  {
+    [[maybe_unused]] auto s1 = sp.first<std::size_t(-1)>(); // expected-error-re at span:* {{static_assert failed{{( due to requirement '.*')?}} "Count out of range in span::first()"}}
+  }
+
+  return 0;
+}

diff  --git a/libcxx/test/std/containers/views/span.sub/first.pass.cpp b/libcxx/test/std/containers/views/span.sub/first.pass.cpp
index f2e77b597b28..0e0dd7278a29 100644
--- a/libcxx/test/std/containers/views/span.sub/first.pass.cpp
+++ b/libcxx/test/std/containers/views/span.sub/first.pass.cpp
@@ -15,7 +15,7 @@
 //
 // constexpr span<element_type, dynamic_extent> first(size_type count) const;
 //
-//  Requires: 0 <= Count && Count <= size().
+//  Requires: Count <= size().
 
 
 #include <span>

diff  --git a/libcxx/test/std/containers/views/span.sub/last.fail.cpp b/libcxx/test/std/containers/views/span.sub/last.fail.cpp
new file mode 100644
index 000000000000..634068967dd2
--- /dev/null
+++ b/libcxx/test/std/containers/views/span.sub/last.fail.cpp
@@ -0,0 +1,40 @@
+// -*- C++ -*-
+//===------------------------------ span ---------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===---------------------------------------------------------------------===//
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
+
+// <span>
+
+// template<size_t Count>
+//  constexpr span<element_type, Count> last() const;
+//
+// constexpr span<element_type, dynamic_extent> last(size_type count) const;
+//
+//  Requires: Count <= size().
+
+#include <span>
+
+#include "test_macros.h"
+
+constexpr int carr[] = {1, 2, 3, 4};
+
+int main(int, char**) {
+  std::span<const int, 4> sp(carr);
+
+  //  Count too large
+  {
+    [[maybe_unused]] auto s1 = sp.last<5>(); // expected-error-re at span:* {{static_assert failed{{( due to requirement '.*')?}} "Count out of range in span::last()"}}
+  }
+
+  //  Count numeric_limits
+  {
+    [[maybe_unused]] auto s1 = sp.last<std::size_t(-1)>(); // expected-error-re at span:* {{static_assert failed{{( due to requirement '.*')?}} "Count out of range in span::last()"}}
+  }
+
+  return 0;
+}

diff  --git a/libcxx/test/std/containers/views/span.sub/last.pass.cpp b/libcxx/test/std/containers/views/span.sub/last.pass.cpp
index 6e0fb3c1d60e..2c4837901280 100644
--- a/libcxx/test/std/containers/views/span.sub/last.pass.cpp
+++ b/libcxx/test/std/containers/views/span.sub/last.pass.cpp
@@ -15,7 +15,7 @@
 //
 // constexpr span<element_type, dynamic_extent> last(size_type count) const;
 //
-//  Requires: 0 <= Count && Count <= size().
+//  Requires: Count <= size().
 
 
 #include <span>