[libcxx-commits] [PATCH] D86612: [libunwind] Enable the SEH unwinding codepaths if building in MSVC mode

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 27 13:22:20 PDT 2020


mstorsjo added a comment.

In D86612#2242965 <https://reviews.llvm.org/D86612#2242965>, @compnerd wrote:

> I don't think that this is entirely true.  I believe it is possible to disable SEH with cl, so I think that it is better to conditionalize it as `if defined(__SEH__) || defined(_SEH)` since IIRC, `_SEH` is the define that `cl` uses.

Hmm, I don't see it being defined with cl.exe as far as I can see, and in any case, clang-cl doesn't define it either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86612/new/

https://reviews.llvm.org/D86612



More information about the libcxx-commits mailing list