[libcxx-commits] [libcxx] 3f8a0ec - [libcxx] Fix the broken test after D82657.

Haojian Wu via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 27 12:12:21 PDT 2020


Author: Haojian Wu
Date: 2020-08-27T21:12:11+02:00
New Revision: 3f8a0ecdaa634e4ef9ec29665db7c82b874422b5

URL: https://github.com/llvm/llvm-project/commit/3f8a0ecdaa634e4ef9ec29665db7c82b874422b5
DIFF: https://github.com/llvm/llvm-project/commit/3f8a0ecdaa634e4ef9ec29665db7c82b874422b5.diff

LOG: [libcxx] Fix the broken test after D82657.

Differential Revision: https://reviews.llvm.org/D86685

Added: 
    

Modified: 
    libcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp b/libcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp
index b8c9c72c93a1..5dea3cb7cc17 100644
--- a/libcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp
+++ b/libcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp
@@ -37,6 +37,8 @@ int main(int, char**) {
     SPtr<3> s3(nullptr, Deleter{}); // OK
   }
   // expected-error-re at memory:* 2 {{static_assert failed{{.*}} "default_delete cannot be instantiated for function types"}}
+  // FIXME: suppress this bogus diagnostic, see https://reviews.llvm.org/D86685.
+  // expected-error at memory:* 0+ {{no member named 'value' in}}
   {
     SPtr<4> s4(getFn<4>()); // expected-note {{requested here}}
     SPtr<5> s5(getFn<5>(), std::default_delete<FnType<5>>{}); // expected-note {{requested here}}


        


More information about the libcxx-commits mailing list