[libcxx-commits] [PATCH] D86685: [libcxx] Fix the broken test after D82657.

Haojian Wu via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 27 11:37:15 PDT 2020


hokein added a comment.

In D86685#2242545 <https://reviews.llvm.org/D86685#2242545>, @ldionne wrote:

> In that case, please use `// expected-error at memory:* 0+ {{no member named 'value' in}}` and add a proper FIXME comment with a link to this review or similar. The `0+` will make sure the test passes whether or not Clang emits the secondary diagnostic.

Thanks. Added one. I will followup to fix this bogus diagnostic in clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86685/new/

https://reviews.llvm.org/D86685



More information about the libcxx-commits mailing list