[libcxx-commits] [PATCH] D86685: [libcxx] Fix the broken test after D82657.

[Sam McCall via Phabricator via libcxx-commits]

sammccall added a comment.

> Strangely, -Xclang -fno-recovery-ast-type doesn't make it go away - how sure are we that your patch is the culprit? And how sure are we that those flags work properly?

Turns out this is an existing clang bug, and my simplified testcase shows a variant that is broken with or without `-frecovery-ast-type`.

So it's good that libcxx happens not to be triggering the bug on this codepath at the moment, but it's mostly getting lucky.

ISTM the best path is to suppress this failure (like in this patch, but with a FIXME) and then try to fix the latent clang bug that was uncovered.
(These sort of FIXMEs are pretty common with secondary diagnostics and there's still a net improvement)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86685/new/

https://reviews.llvm.org/D86685