[libcxx-commits] [PATCH] D86685: [libcxx] Fix the broken test after D82657.

Thu Aug 27 06:14:26 PDT 2020

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

In D86685#2241223 <https://reviews.llvm.org/D86685#2241223>, @hokein wrote:

> I'm not sure this is the correct solution to fix the failing test due to the new diagnostic of the compiler.
>
> The test will pass if it runs under the trunk clang; and it fails if it runs under an old clang;
>
> After D82657 <https://reviews.llvm.org/D82657>
>
> - it breaks one of the builtbots: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/945, this buildbot seems to use trunk clang;
> - there are other buildbots (e.g. http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03/builds/3823/steps/test.libcxx/logs/stdio) which uses `/usr/local/bin/clang++`
>
> Any ideas?

The correct fix is to ensure that Clang doesn't produce a second diagnostic, since that second diagnostic is bogus. Working around the issue by annotating the libc++ tests isn't the right solution.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86685/new/

https://reviews.llvm.org/D86685