[libcxx-commits] [PATCH] D86540: [libcxxabi, libunwind] support running tests in standalone mode

Dominik Montada via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 25 07:19:59 PDT 2020


gargaroff added a comment.

We require this patch for our downstream baremetal target to be able to run the test suites of both libraries on our target.

I'm not sure whether the check in libcxxabi was simply outdated or if we will require some type of check there.

As for the libunwind part: I mostly copy-pasted the `HandleOutOfTreeLLVM.cmake` from libcxxabi and adapted it to libunwind in places where it was necessary. I compared the previous logic with the new one and although I did find some differences, mostly related to llvm-lit, most of them did not seem to be actually required.

Please note however that I was only able to test our downstream use-case. I hope this doesn't break anything. Please let me know if you spot anything and how we could fix that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86540/new/

https://reviews.llvm.org/D86540



More information about the libcxx-commits mailing list