[libcxx-commits] [PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

Mon Aug 24 09:28:32 PDT 2020

teemperor added a comment.

In D86308#2229936 <https://reviews.llvm.org/D86308#2229936>, @tambre wrote:

> In D86308#2229901 <https://reviews.llvm.org/D86308#2229901>, @teemperor wrote:
>
>> Sorry, just got around to check this out. With the new workaround this seems to work on macOS (the initial patch did produce the same error).
>
> Many thanks!
> I've submitted an upstream CMake MR to hopefully fix this <https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5152>. I'd appreciate if you could test that too. There's an example testcase in CMake issue 20771 <https://gitlab.kitware.com/cmake/cmake/-/issues/20771>.

With that CMake patch your original patch compiles just fine on macOS. Feel free to add a FIXME that this workaround can be removed when the CMake version you merged this is because the new minimum required. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86308/new/

https://reviews.llvm.org/D86308