[libcxx-commits] [PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

Fri Aug 21 00:43:57 PDT 2020

tambre added a comment.

In D86308#2229199 <https://reviews.llvm.org/D86308#2229199>, @mstorsjo wrote:

> Just FWIW, a similar change was made in libunwind earlier (c48974ffd7d1676f79d39d3b1e70f07d3a5e2e44 <https://reviews.llvm.org/rGc48974ffd7d1676f79d39d3b1e70f07d3a5e2e44>), which then required workarounds for cmake issues on both mingw and macos (see b780df052dd2b246a760d00e00f7de9ebdab9d09 <https://reviews.llvm.org/rGb780df052dd2b246a760d00e00f7de9ebdab9d09> and d4ded05ba851304b26a437896bc3962ef56f62cb <https://reviews.llvm.org/rGd4ded05ba851304b26a437896bc3962ef56f62cb>) to reintroduce the code for building the asm code as C.

Thanks for the links! That helps a ton.
I've unified the workaround code to be the same and expanded the comments in compiler-rt to refer to the relevant upstream issues and to each other.

In D86308#2229176 <https://reviews.llvm.org/D86308#2229176>, @phosek wrote:

> In D86308#2228917 <https://reviews.llvm.org/D86308#2228917>, @tambre wrote:
>
>> I'm pretty sure `add_asm_sources()` has nothing to do. The ASM language is enabled by compiler-rt anyway and CMake can recognize the files as assembly anyway.
>
> Can we remove that function altogether then?

Seems we'll need it for the workarounds.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86308/new/

https://reviews.llvm.org/D86308