[libcxx-commits] [PATCH] D86041: RFC [libunwind] Convert the register restore functions to C functions

Saleem Abdulrasool via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 20 09:35:59 PDT 2020


compnerd added a comment.

I think that the confusing part is that it is not that they are C functions, they are still assembly, but with C calling convention.  I think that you should state that in the description as it currently reads as though they are written in C, which they are not.

Right, there may need to be a thunk for some platforms but if the compiler does treat the call to the symbol as a tail call, that is fine.

Can you share the reasoning for building libunwind with MSVC?  In particular, the calling convention isn't identical to the Unix calling convention, so you will need to use the Microsoft unwinder to get interoperability with MS ABI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86041/new/

https://reviews.llvm.org/D86041



More information about the libcxx-commits mailing list