[libcxx-commits] [PATCH] D77606: [libcxxabi] Add macro for changing functions to support the relative vtables ABI

Thu Aug 13 13:07:41 PDT 2020

ldionne added a comment.

In D77606#2216493 <https://reviews.llvm.org/D77606#2216493>, @leonardchan wrote:

> In D77606#2215442 <https://reviews.llvm.org/D77606#2215442>, @ldionne wrote:
>
>> In D77606#2214538 <https://reviews.llvm.org/D77606#2214538>, @mcgrathr wrote:
>>
>>> Long-term, I think we want this to be keyed entirely on a compiler predefine and not chosen in cmake.
>>
>> Actually, I'd like to use that approach now. @leonardchan is that possible?
>
> Can do. Something like D85924 <https://reviews.llvm.org/D85924>?

Yeah, something like that. I'm not a big fan of the name of the macro, but that's a different story to be discussed in D85924 <https://reviews.llvm.org/D85924>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77606/new/

https://reviews.llvm.org/D77606