[libcxx-commits] [PATCH] D84943: [libc++] Remove workarounds for missing rvalue references

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 3 08:27:00 PDT 2020


ldionne added a comment.

In D84943#2189145 <https://reviews.llvm.org/D84943#2189145>, @zoecarver wrote:

> Not sure if this is the right patch or if it would be better as a follow-up, but there are a lot of places (vector, unique_ptr, valarray, etc.) where rvalues (or in the case of unique_ptr, lvalue references) are gated on `_LIBCPP_CXX03_LANG` rather than `_LIBCPP_HAS_NO_RVALUE_REFERENCES`. We should probably try to remove those workarounds as well.

I fully agree. I was trying to get rid of `_LIBCPP_HAS_NO_RVALUE_REFERENCES` specifically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84943/new/

https://reviews.llvm.org/D84943



More information about the libcxx-commits mailing list