[libcxx-commits] [PATCH] D77786: [AArch64] Add v8.5 Branch Target Identification support.

Daniel Kiss via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 3 05:24:31 PDT 2020


danielkiss marked an inline comment as done.
danielkiss added inline comments.


================
Comment at: libunwind/src/assembly.h:51
 
+#if defined(__aarch64__) && defined(__ARM_FEATURE_BTI_DEFAULT)
+  .pushsection ".note.gnu.property", "a" SEPARATOR                             \
----------------
compnerd wrote:
> I'm not sure if the `defined(__aarch64__)` check is absolutely required, but it doesn't give the wrong result.
Thanks, fixed it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77786/new/

https://reviews.llvm.org/D77786



More information about the libcxx-commits mailing list