[libcxx-commits] [PATCH] D78816: Fix ostream for complex numbers with fixed field width

Thu Apr 30 14:32:58 PDT 2020

cantonios added a comment.

In D78816#2013207 <https://reviews.llvm.org/D78816#2013207>, @dexonsmith wrote:

> @cantonios, thanks for working on this.  I'll let @ldionne or others review in detail, but I have two high-level notes:
>
> - Given that this is a partial revert of c3478eff7a65d6a77b34e756eabc7176a2b422e8 <https://reviews.llvm.org/rGc3478eff7a65d6a77b34e756eabc7176a2b422e8> (reviewed at https://reviews.llvm.org/D71214) I think the commit message should mention that commit.
> - To avoid the same issue in the future, I think this needs a test!  Probably somewhere in `libcxx/test/std/numerics/complex.number` makes sense.

Done.

In D78816#2013597 <https://reviews.llvm.org/D78816#2013597>, @ldionne wrote:

> Ugh, sorry I hadn't seen that before. The patch LGTM but I agree we should add a test -- @cantonios can you add one?

Done.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78816/new/

https://reviews.llvm.org/D78816