[libcxx-commits] [PATCH] D76102: Enforce that libc++ and libc++abi are built in a monorepo layout

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 29 09:06:12 PDT 2020


ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/CMakeLists.txt:4
 
+if (NOT IS_DIRECTORY "${CMAKE_CURRENT_LIST_DIR}/../libcxxabi")
+  message(FATAL_ERROR "libc++ now requires being built in a monorepo layout with libcxxabi available")
----------------
mgorny wrote:
> How does this interface with using other C++ ABI libraries?
It makes no difference -- the requirement is only that the libcxxabi sources be available. Essentially, we want to start taking advantage of the fact that we have the monorepo to stop duplicating code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76102/new/

https://reviews.llvm.org/D76102





More information about the libcxx-commits mailing list