[libcxx-commits] [PATCH] D78787: [libcxx][libcxxabi][libunwind] Use libgcc on Android

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

In D78787#2001307 <https://reviews.llvm.org/D78787#2001307>, @danalbert wrote:

> @srhines to confirm that this won't break our toolchain build, and @rprichard because he's the one looking more closely at libunwind these days.
>
> If they don't have any objections then this is fine with me, though I do wonder if we can just make use of `-nostdlib++` or `-stdlib=libc++` as needed here (libc++ doesn't use these everywhere because it's a clang only thing, but Android is a clang only platform so we could do that if we have the option).


Not sure I understand. This is the build of libc++ itself, and it's already using `-nostdlib++` (cos you don't wanna link libc++ against another C++ library). It still needs to link against the runtime library though, and on Android, that runtime library is gonna be libgcc (or compiler-rt, but that's already supported). I'm fixing the runtime library search to use libgcc instead of libgcc_s on Android, since the latter doesn't exist.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78787/new/

https://reviews.llvm.org/D78787