[libcxx-commits] [PATCH] D78245: [LIT] Make `%T` unique for every test

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 15 14:55:23 PDT 2020


EricWF marked 2 inline comments as done.
EricWF added inline comments.


================
Comment at: llvm/utils/lit/lit/TestRunner.py:1062
     execdir,execbase = os.path.split(execpath)
-    tmpDir = os.path.join(execdir, 'Output')
+    tmpDir = os.path.join(execdir, 'Output', execbase + '.dir')
     tmpBase = os.path.join(tmpDir, execbase)
----------------
@ldionne Here's the relevant LIT change.


================
Comment at: llvm/utils/lit/lit/TestRunner.py:1500
+    tmpDir = os.path.dirname(tmpBase)
+    if os.path.isdir(tmpDir):
+        shutil.rmtree(tmpDir)
----------------
This change probably isn't needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78245/new/

https://reviews.llvm.org/D78245





More information about the libcxx-commits mailing list