[libcxx-commits] [PATCH] D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC

Fri Apr 10 11:36:23 PDT 2020

ldionne added a subscriber: sbc100.
ldionne added a comment.

In D77370#1973982 <https://reviews.llvm.org/D77370#1973982>, @tambre wrote:

> I've tested it out now and `CMAKE_POSITION_INDEPENDENT_CODE=ON` suffices.
>  Thanks for reviewing and all the info.
>
> It seems this same way should work for libc++abi.
>  Would it make sense to remove `LIBCXXABI_ENABLE_PIC` for consistency?

Yes, I think it would make sense.

However, see the discussion in https://reviews.llvm.org/D60049. I think we should get @phosek and @sbc100 's inputs. Folks, is there a reason why controlling whether libc++abi is built with PIC with `CMAKE_POSITION_INDEPENDENT_CODE` in the cache is not sufficient?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77370/new/

https://reviews.llvm.org/D77370