[libcxx-commits] [PATCH] D77697: libc++: adjust modulemap for non-modular C

Richard Smith - zygoloid via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 8 17:56:52 PDT 2020


rsmith added a comment.

In D77697#1968998 <https://reviews.llvm.org/D77697#1968998>, @joerg wrote:

> This fixes the module build of clang for me.


Are you building with or without `-fmodules-local-submodule-visibility` (`cmake -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=ON`)? If you don't use that, this sort of random weirdness is going to come up a lot. And if you do use that setting, then this patch shouldn't make any difference; if it does, we should dig into why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77697/new/

https://reviews.llvm.org/D77697





More information about the libcxx-commits mailing list