[libcxx-commits] [PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 7 05:55:09 PDT 2020


ldionne added inline comments.


================
Comment at: clang/test/SemaObjCXX/type-traits-is-pointer.mm:1
+// RUN: %clang_cc1 -fsyntax-only -fobjc-arc -fobjc-runtime-has-weak -verify %s
+// expected-no-diagnostics
----------------
ldionne wrote:
> Why do you run this through `-verify`? Can't you just drop that and the `// expected-no-diagnostics` bit too?
Actually, never mind this. Someone pointed to me offline that using `clang-verify` has the benefit that no other diagnostics are going to be emitted, which is true. This is fine by me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77519/new/

https://reviews.llvm.org/D77519





More information about the libcxx-commits mailing list