[libcxx-commits] [libcxx] 276d2b7 - [libc++] 2/N: Enable the new libc++ testing format by default

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 6 15:37:26 PDT 2020


Author: Louis Dionne
Date: 2020-04-06T18:35:17-04:00
New Revision: 276d2b78ce4d9753ed9e46576b4c5ab27d0ebf45

URL: https://github.com/llvm/llvm-project/commit/276d2b78ce4d9753ed9e46576b4c5ab27d0ebf45
DIFF: https://github.com/llvm/llvm-project/commit/276d2b78ce4d9753ed9e46576b4c5ab27d0ebf45.diff

LOG: [libc++] 2/N: Enable the new libc++ testing format by default

Both test formats are equivalent, so this *should* not be a problem.
We've fixed a couple of failures uncovered by the first time we tried
making the switch, so this new attempt should go even farther.

If failures are noticed, it should be fine to revert this commit, but
please give a heads up afterwards so we know to address the issues!

Also note that it is still possible to use the old format by passing
`--param=use_old_format=True` when running Lit for the time being.

Added: 
    

Modified: 
    libcxx/test/lit.cfg

Removed: 
    


################################################################################
diff  --git a/libcxx/test/lit.cfg b/libcxx/test/lit.cfg
index 89c465cfe86d..ce98c636e5ab 100644
--- a/libcxx/test/lit.cfg
+++ b/libcxx/test/lit.cfg
@@ -55,9 +55,10 @@ config_module = __import__(config_module_name, fromlist=['Configuration'])
 configuration = config_module.Configuration(lit_config, config)
 configuration.configure()
 configuration.print_config_info()
-if lit_config.params.get('use_new_format', False):
-    lit_config.note("Using the experimental libc++ testing format")
+if lit_config.params.get('use_old_format', False):
+    lit_config.note("Using the old libc++ testing format")
+    config.test_format = configuration.get_test_format()
+else:
+    lit_config.note("Using the new libc++ testing format")
     import libcxx.test.newformat
     config.test_format = libcxx.test.newformat.CxxStandardLibraryTest()
-else:
-    config.test_format = configuration.get_test_format()


        


More information about the libcxx-commits mailing list